ext/mysqli tests "using password" optional in error messages

[grooverdan]

In MariaDB the "using password" may not exist in the error message

e.g:
https://buildbot.mariadb.org/#/builders/237/builds/4279/steps/5/logs/stdio

[cmb69]

Thank you for the PR! I'm not particularly concerned about these changes, but I wonder why the tests pass for me locally with MariaDB 10.5.13.0 (and almost certainly also in our CI), but fail for you.

Also note that PHP 8.0 is no longer actively supported, so this could target PHP-8.1 at most.

[grooverdan]

Thank you for the PR! I'm not particularly concerned about these changes, but I wonder why the tests pass for me locally with MariaDB 10.5.13.0 (and almost certainly also in our CI), but fail for you.

If unix socket auth (or Windows auth_pipe) is used there is no "using password" in the error message.

Its only when a true mysql_native_password authentication is used that the "using password" occurs:

MariaDB [(none)]> alter user dan@localhost identified via mysql_native_password;
Query OK, 0 rows affected (0.001 sec)

MariaDB [(none)]> set password = password('bob');
Query OK, 0 rows affected (0.002 sec)

MariaDB [(none)]> ^DBye

$ mc -pdd
ERROR 1045 (28000): Access denied for user 'dan'@'localhost' (using password: YES)

[cmb69]

Its only when a true mysql_native_password authentication is used that the "using password" occurs:

Ah! Thank you.

[cmb69]

Thank you!

[grooverdan]

Any reason for a non-8.1 fix?

[cmb69]

Any reason for a non-8.1 fix?

Apparently, GH is confused. b6b4a62 is on PHP-8.1 (https://github.com/php/php-src/blob/PHP-8.1/ext/mysqli/tests/mysqli_connect_oo.phpt), and I merged upwards (0ac9e8e and 4ae1f08). (PHP 8.0 is no longer actively supported)

[grooverdan]

Ack. Sorry did see this eventually.