Enforce literals in certain macros #10111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
zend_string_equals_literal_ci
andzend_string_equals_literal
macros are designed only for literals. This is a standards compliant
trick to ensure they are literals. It relies on the fact that two
adjacent string literals are concatenated. For example, these are the
same:
Since literals are ensured, use
sizeof(...) - 1
instead ofstrlen
.I spot checked usages visually, but running the CI in case it finds any
non-literal uses.