Initialize ping_auto_globals_mask to prevent undefined behaviour

[nielsdos]

ping_auto_globals_mask was not initialized on all paths towards script->ping_auto_globals_mask = ping_auto_globals_mask;, which is undefined behaviour.

[iluuu1994]

Nice catch! We don't currently run preloading jobs with MSAN and only have a single test for auto_globals_jit (sapi/phpdbg/tests/info_001.phpt) which is why I guess this was never caught. A test for this could be added though (forcing both preloading and auto_globals_jit through the --INI-- section).

[nielsdos]

Thanks for the review.
I've added a test to test the codepath which previously had UB.

[iluuu1994]

Thank you! That looks perfect! Just a tiny nit.

[nielsdos]

Thanks. I updated the test. :)
Failure in Travis "No output has been received in the last 10m0s" seems unrelated.

[iluuu1994]

Looks good, thank you! I'll merge this tonight when I'm off work (this requires manual merging as it's targeting an older branch).

[nielsdos]

Thanks for the merge.
I think you forgot to commit the regression test though, I can't seem to find it in the master branch.

[iluuu1994]

@nielsdos Oh, sorry! I'll fix that in a second.

[iluuu1994]

I picked the wrong commit to reset to. Should be good now. Thanks for noticing.