mb_convert_kana is broken in PHP8.2.0

[akira345]

Description

mb_convert_kana is broken in PHP8.2.0.
The code below works fine in PHP8.1.13, but returns Fatal error: Uncaught ValueError: mb_convert_kana(): Argument #2 ($mode) must not combine 'h' and 'k' flags in PHP8.2.0.

The following code:

<?php
$ret = mb_convert_kana("fooあいうエオ","rnaskh","UTF-8");
print($ret);

Resulted in this output:

// for PHP8.1.13
fooｱｲｳｴｵ

// for PHP8.2.0
Fatal error: Uncaught ValueError: mb_convert_kana(): Argument #2 ($mode) must not combine 'h' and 'k' flags

But I expected this output instead:

// for PHP8.1.13
fooｱｲｳｴｵ

// for PHP8.2.0
fooｱｲｳｴｵ

PHP Version

PHP 8.2.0

Operating System

Debian GNU/Linux 11

[youkidearitai]

Since PHP 8.2 it now does a $mode check, but hk is valid.

From mb_convert_kana's manual

• h flag is "Convert "zen-kaku hira-gana"(ひらがな) to "han-kaku kata-kana"(ｶﾀｶﾅ) "
• k flag is Convert "zen-kaku kata-kana"(カタカナ) to "han-kaku kata-kana"(ｶﾀｶﾅ) "

Therefore, hk can combine.

[cmb69]

This check has been introduced with dcaa010. @alexdowad, can you please check this issue?

[alexdowad]

Thanks for the report. You are right that hk does indeed make sense.

Will fix ASAP.

[alexdowad]

Any other feedback on which combinations of flags for mb_convert_kana do and do not make sense is also welcome.

We want to avoid:

1. Combinations which are contradictory, such as HK ("convert all HW kana to FW hiragana" but also "convert all HW kana to FW katakana").
2. Combinations which would make mb_convert_kana convert X to Y and then Y back to X again, such as "convert all HW kana to FW kana" but also "convert all FW kana to HW kana".