Fix memory leak in posix_ttyname() #10190
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmb69
approved these changes
Dec 30, 2022
There was a problem hiding this comment.
Ah, good catch! Not sure about the test case, but if in doubt, we can leave that out.
The other thing I don't get is why we only use ttyname_r() in ZTS builds.
Well, we use ttyname_r() on in ZTS builds, if it is available. Otherwise we're falling back to ttyname which is apparently available everywhere. Using the reentrant function is not necessary for NTS builds, and likely a bit more performant (might not need to allocate memory under the hood).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how to write a test case for this.
The other thing I don't get is why we only use
ttyname_r()in ZTS builds.