Implement GMP::__construct #10225
Closed
Implement GMP::__construct #10225
+109
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Jan 5, 2023
| var_dump(new GMP("12", 999)); | ||
| } catch (ValueError $e) { | ||
| echo $e->getMessage() . "\n"; | ||
| } |
There was a problem hiding this comment.
Just for the sake of completeness, add a test with a non-numeric string as the number (e.g. 'hello', or '')
89d4388 to
9931f43
Compare
|
Thanks for the review, I updated the patch with your suggestions. |
|
I checked the failures, they are unrelated to the code changes. |
|
@ramsey @saundefined @adoy What do you think about landing this in 8.2? |
adoy
approved these changes
Jan 17, 2023
|
I see no issue adding this to 8.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes GH-10158
Fixes GH-10155
Implements a proper constructor for GMP as discussed in both GH-10158 and https://externals.io/message/119216.
Targeting 8.2.x as proposed on the mailing list thread.
cc @Girgias
Not sure if I did everything correctly, looking forward for reviews :)