Skip to content

add file path in opcache lock file error #10331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

jfcoz
Copy link
Contributor

@jfcoz jfcoz commented Jan 15, 2023

Make error more verbose with the lock file path

@cmb69
Copy link
Member

cmb69 commented Jan 15, 2023

Thank you for the PR!

I don't think that "opcache" to the output makes much sense, since this is written to the OPcache log (not the general error log, anyway). I am not sure about lockfile_name; maybe lockfile_path makes more sense.

@jfcoz
Copy link
Contributor Author

jfcoz commented Jan 15, 2023

I get this error in the output of a container, trying to use a readonly filesystem, so I had no indication on the opcache log.

Yes, logfile_path can be sufficient.

@jfcoz jfcoz force-pushed the opcache_lock_error branch from 42d68fd to 50fcf51 Compare January 15, 2023 18:31
@dstogov dstogov merged commit 36b194b into php:master Oct 9, 2023
@dstogov
Copy link
Member

dstogov commented Oct 9, 2023

Sorry for missing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants