Skip to content

Handle exceptions from __toString in XXH3's initialization #10352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Handle exceptions from __toString in XXH3's initialization #10352

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Jan 16, 2023 •
edited
Loading

The initialization routine for XXH3 was not prepared for exceptions from seed. Fix this by using try_convert_to_string.

For discussion, please see:
#10305 (comment) and #10305 (comment)

Girgias
Girgias approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after reading the discussion.

@Girgias Girgias self-assigned this Jan 17, 2023
@Girgias Girgias closed this in 7463e70 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees

@Girgias Girgias

Labels
Extension: hash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nielsdos @Girgias @devnexen