Remove pcre_get_compiled_regex_ex() #10354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
Indeed looking at https://sourcegraph.com/search?q=context:global+pcre_get_compiled_regex_ex+-file:ext/pcre/php_pcre.c+-file:ext/pcre/php_pcre.h&patternType=standard&sm=1&groupBy=repo no one seems to be using this. Maybe just add an entry in UPGRADING.INTERNALS just to be sure.
ff426a6 to
e0f8c70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please correct me if I am wrong, but this method is not used internally within PHP. If any extension wants to use it they can still use
pcre_get_compiled_regexas it does the same thing.