Remove unused php_stream_tell() result #10365
Closed
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, actually, the line was just moved. So it was there even before. |
cmb69
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Indeed, php_stream_tell() has no side effects whatsoever, so it can be removed.
It was assigned to an unused variable till 323b273, and apparently from when that call had been introduced.
I've just retriggered the failed GH action (Travis failure is unrelated anyway). Assuming that passes, this looks good to me.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I found this using a static analysis pass that looks for unused results in code. I manually verified this.