Improve the optimizer's check if a function is a prototype or not #10467
Conversation
|
|
Ugh, can't believe I missed that... Should be fixed now. |
Zend/Optimizer/zend_optimizer.c
Outdated
| bool can_be_overridden = (fbc->common.fn_flags & ZEND_ACC_FINAL) == 0 && | ||
| (fbc->common.scope->ce_flags & ZEND_ACC_FINAL) == 0; | ||
| if (can_be_overridden) { |
There was a problem hiding this comment.
It doesn't make sense to introduce can_be_overridden variable. The condition may be used directly in the following if statement.
There was a problem hiding this comment.
I'll change that thanks.
About anonymous classes, see #10467 (comment)
There was a problem hiding this comment.
I'll change that thanks. About anonymous classes, see #10467 (comment)
Ugh, this is like overriding constants values through reflection API in Java :)
Anyway, your patch is right now.
Currently, a function is considered a prototype if the function is not marked as final. However, a class marked as final also make it impossible for a function to be overridden. Therefore, we know in this case too that the function is not a prototype. This allows the type inference algorithm to determine some types more precisely, and can allow for more optimizations of the instructions. Additionally, place some computation of the flags in their respective blocks as a micro-optimization. Note: anonymous classes *can* be extended (see test Zend/tests/anon/011.phpt). Therefore we don't optimize this case.
|
Pushed the change to get rid of the variable. Thanks. |
Currently, a function is considered a prototype if the function is not marked as final. However, a class marked as final or an anonymous class also make it impossible for a function to be overridden. Therefore, we know in these 2 cases too that the function is not a prototype. This allows the type inference algorithm to determine some types more precisely, and can allow for more optimizations of the instructions. Additionally, place some computation of the flags in their respective blocks as a micro-optimization.