Stop copying internal functions into each thread #10517
Conversation
It seems we don't copy internal methods for a long time, so this shouldn't be a problem. We had to copy functions in PHP-5 times, but it seems we just forgot to remove this. It's possible that some third-part extensions (e.g. profilers, tracers, debuggers) modify internal functions. After this change that may cause race conditions in ZTS build (but we already jave the same behavior for internal methods). Observer API should provide necesssary functionality to avoid shared structures modification.
|
I support this. In fact I thought this was already the case :-D Also, it does not even make sense to have the behavior separate from classes, where we actually already reference the global class pointer, and thereby indirectly provide access to the global zend_internal_function pointer on the class methods. |
I also was surprised :) |
|
@dstogov Given that it fixes an actual crash (#10473) and given that third party extensions cannot modify internal methods arbitrarily at runtime, I assume the impact of this change is low enough and the benefit high enough to be merged into PHP 8.1 as well. It would be extremely surprising to me if any extension had particular behaviour for internal functions, but not internal methods. |
I afraid, we can't merge this into old versions. This definitely may change behavior of some third-party extensions (even if they are already broken). |
|
May be some one would propose a more clean way to do the same? |
It seems we don't copy internal methods for a long time, so this shouldn't be a problem. We had to copy functions in PHP-5 times, but it seems we just forgot to remove this.
It's possible that some third-part extensions (e.g. profilers, tracers, debuggers) modify internal functions. After this change that may cause race conditions in ZTS build (but we already have the same behavior for internal methods). Observer API should provide the necesssary functionality to avoid shared structures modification.