ext/curl: suppress -Wdeprecated-declarations #10531
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but you accidentally included one additional commit though. |
9364ab5 to
523201e
Compare
Oops, fat-fingered stgit? Fixed now. |
|
Thank you ! |
|
Would be probably also good to create issues for the actual deprecations as we might need to eventually do something about them. For example if there is no way around them, we should deprecate such functionality in PHP as well... |
MaxKellermann
added a commit
to CM4all/php-src
that referenced
this pull request
Feb 10, 2023
Disable the warning before including curl_arginfo.h. (Follow-up for php#10531)
MaxKellermann
added a commit
to CM4all/php-src
that referenced
this pull request
Mar 7, 2023
iluuu1994
pushed a commit
that referenced
this pull request
Mar 22, 2023
Disable the warning before including curl_arginfo.h. (Follow-up for #10531)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.