makedist: Use fixed owner/group in generated tarball #10613
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the amount of system-dependent data within the tarball and makes it more reproducible. Instead of the information of the release manager that generates the tarball, the tarball will include the fixed 0:0 value as owner:group.
ramsey
approved these changes
Feb 17, 2023
|
Thanks! |
|
Note: There still is some "volatile" information. Most notable the dates. Instead of setting them based on the current time, they should likely be set based on the date of the tag / date of the last commit in case of branches. I can recommend the Diffoscope tool to explore the possible issues lurking in reproducibility: https://diffoscope.org/. It was built for Debian's Reproducible Builds project. |
TimWolla
added a commit
that referenced
this pull request
Feb 18, 2023
* PHP-8.2: makedist: Use fixed owner/group in generated tarball (#10613)
crrodriguez
pushed a commit
to crrodriguez/php-src
that referenced
this pull request
Feb 21, 2023
This reduces the amount of system-dependent data within the tarball and makes it more reproducible. Instead of the information of the release manager that generates the tarball, the tarball will include the fixed 0:0 value as owner:group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the amount of system-dependent data within the tarball and makes it more reproducible. Instead of the information of the release manager that generates the tarball, the tarball will include the fixed 0:0 value as owner:group.
Specifically requesting a review from @ramsey, because https://phpc.social/@ramsey/109876124091468563. Feel free to request additional reviews from whomever you consider helpful.