ext: make lots of internal functions static #10650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Feb 21, 2023
| ZEND_INI_MH(OnUpdateDefaultHandler) | ||
| static ZEND_INI_MH(OnUpdateDefaultHandler) |
There was a problem hiding this comment.
Would it make sense to modify the definition of ZEND_INI_MH to include the static?
There was a problem hiding this comment.
I thought about that, but after I saw it's already used that way a lot (54 times), I decided it's a whole different refactoring case and didn't check if it breaks anything. e.g.:
Line 101 in e093ac4
There was a problem hiding this comment.
Huh, didn't even realize that we were already doing this elsewhere. Makes sense then to just add it here
There was a problem hiding this comment.
And: adding static to the macro would be a breaking change; it would break all extensions which already use static.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.