Minor cleanups in Zend execution APIs #10699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check is always false because of the undefined behaviour rule that says a NULL pointer must never be dereferenced: we already dereference name when checking the cache slot, before the NULL check. So the NULL may be optimised away by the compiler. It looks like the code isn't even supposed to work with name being NULL, so just remove the check.
|
Failure in LINUX_X64_RELEASE_ZTS is |
Girgias
approved these changes
Feb 26, 2023
| if (name == NULL || !ZSTR_LEN(name)) { | ||
| if (!ZSTR_LEN(name)) { |
There was a problem hiding this comment.
Might make sense to add a ZEND_ASSERT(name); at the top of the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor cleanups, descriptions:
This check is always false because of the undefined behaviour rule that
says a NULL pointer must never be dereferenced: we already dereference name
when checking the cache slot, before the NULL check. So the NULL may be
optimised away by the compiler. It looks like the code isn't even
supposed to work with name being NULL, so just remove the check.
Remove always-true check in zend_fetch_static_property_address_ex()
Simplify always-true conditions.