Skip to content

Fix incorrect inheritance cache update #10719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

dstogov
Copy link
Member

@dstogov dstogov commented Feb 27, 2023

No description provided.

@dstogov dstogov merged commit 2e3fc8c into php:PHP-8.2 Feb 27, 2023
dstogov added a commit that referenced this pull request Feb 27, 2023
dstogov added a commit that referenced this pull request Feb 27, 2023
* PHP-8.1:
  Fix incorrect inheritance cache update (#10719)
dstogov added a commit that referenced this pull request Feb 27, 2023
* PHP-8.2:
  Fix incorrect inheritance cache update (#10719)
dstogov added a commit that referenced this pull request Feb 27, 2023
* PHP-8.2:
  Fix incorrect inheritance cache update (#10719)
@iluuu1994
Copy link
Member

@dstogov Could this failure on ARM be related?

https://app.travis-ci.com/github/php/php-src/jobs/596957265

========DIFF========
     object(A)#2 (0) {
     }
003+ php: /home/travis/build/php/php-src/ext/opcache/ZendAccelerator.c:2367: zend_accel_inheritance_cache_add: Assertion `0' failed.
004+ Aborted
005+ 
006+ Termsig=6
003- object(B)#2 (0) {
004- }
005- object(C)#2 (0) {
006- }
007- object(C)#2 (0) {
008- }
========DONE========
FAIL Class order allowed with autoloading (1) [Zend/tests/type_declarations/variance/class_order_autoload1.phpt] 
========DIFF========
     Class A does not exist
003+ php: /home/travis/build/php/php-src/ext/opcache/ZendAccelerator.c:2367: zend_accel_inheritance_cache_add: Assertion `0' failed.
004+ Aborted
    
006+ Termsig=6
004- Fatal error: During inheritance of B with variance dependencies: Uncaught Exception: Class A does not exist in %s:%d
005- Stack trace:
006- #0 %s(%d): {closure}('A')
007- #1 {main} in %s on line %d
========DONE========
FAIL Exception while loading class -- parent case [Zend/tests/type_declarations/variance/loading_exception1.phpt] 
========DIFF========
     Class I does not exist
     Class I does not exist
003+ php: /home/travis/build/php/php-src/ext/opcache/ZendAccelerator.c:2367: zend_accel_inheritance_cache_add: Assertion `0' failed.
004+ Aborted
003- 
004- Fatal error: During inheritance of B with variance dependencies: Uncaught Exception: Class I does not exist in %s:%d
005- Stack trace:
006- #0 %s(%d): {closure}('I')
007- #1 {main} in %s on line %d
========DONE========
FAIL Exception while loading class -- interface case [Zend/tests/type_declarations/variance/loading_exception2.phpt] 
=====================================================================

@dstogov
Copy link
Member Author

dstogov commented Feb 28, 2023

yes, this is definitely related

@dstogov
Copy link
Member Author

dstogov commented Feb 28, 2023

@iluuu1994 the failures should be fixed now

@iluuu1994
Copy link
Member

@dstogov Thank you for the fix 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants