Skip to content

Fix missing readonly modification error with inc/dec in JIT #10746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix missing readonly modification error with inc/dec in JIT #10746

wants to merge 1 commit into from

Conversation

iluuu1994
Copy link
Member

I guess this isn't caught by existing tests because adding a try/catch reverts back to the ZEND_PRE_INC_OBJ handler.

@iluuu1994 iluuu1994 requested a review from dstogov March 2, 2023 00:23
dstogov
dstogov approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made only a quick look over the sources, but this looks fine.

@iluuu1994 iluuu1994 closed this in df93146 Mar 2, 2023
@iluuu1994
Copy link
Member Author

@dstogov Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstogov dstogov dstogov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iluuu1994 @dstogov