Skip to content

Fix #7780, CTE flags for some functions were removed by a mistake #10768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix #7780, CTE flags for some functions were removed by a mistake #10768

wants to merge 2 commits into from

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Mar 3, 2023

I checked all functions from #7780

discussed here: #10729 (comment)

@mvorisek mvorisek changed the title Fix #7780, array_is_list can be evaluated at compile time Fix #7780, some CTE functions were removed by a mistake Mar 3, 2023
@nielsdos
Copy link
Member

nielsdos commented Mar 3, 2023

The changes look correct to me. Thx.

@mvorisek mvorisek changed the title Fix #7780, some CTE functions were removed by a mistake Fix #7780, CTE flags for some function were removed by a mistake Mar 3, 2023
@mvorisek mvorisek changed the title Fix #7780, CTE flags for some function were removed by a mistake Fix #7780, CTE flags for some functions were removed by a mistake Mar 3, 2023
@mvorisek
Copy link
Contributor Author

mvorisek commented Mar 6, 2023

Let's merge it.

@nielsdos
Copy link
Member

nielsdos commented Mar 6, 2023

Unless I'm missing something, it looks like stristr was not part of the list previously, and now it is. While we can make it CTE, I believe it is strictly speaking wrong to do for non-master?

@mvorisek
Copy link
Contributor Author

mvorisek commented Mar 6, 2023

given stripos for example is CTE, I belive it is ok for consistency

@nielsdos
Copy link
Member

nielsdos commented Mar 6, 2023

While I tend to agree that it's quite silly not to do it for stripos, I don't want to make the decision by myself to also include this one in a stable release as that's not strictly speaking part of the bugfix. And I don't want to accidentally break any rules here. The other changes are fine for me. Why don't you add stripos instead to your other PR about CTE? Otherwise, we could ask someone else's opinion about stripos.

@mvorisek
Copy link
Contributor Author

mvorisek commented Mar 7, 2023

I have updated this PR to be strict fix of #7780 only. New CTE functions will be added in #10771 for master only.

iluuu1994
iluuu1994 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

nielsdos
nielsdos approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now. :)
I'll merge it tonight, squashed. I'll also update the title of the final commit because this fixes a bug in 7780, it does not fix a bug reported in that issue.

@nielsdos nielsdos closed this in 411cd04 Mar 7, 2023
@mvorisek mvorisek deleted the fix_cte_stub branch March 7, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
Extension: gd Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvorisek @nielsdos @iluuu1994