Enable GitHub actions cancel-in-progress for PRs #10799
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5534706 to
351637e
Compare
|
Unfortunately, notification e-mails on cancel can't be disabled 🙁 community/community#13015 |
TimWolla
reviewed
Mar 6, 2023
Pushing many commits to a pull request in a short amount of time can stall the merge builds and also wastes energy unnecessarily. github.head_ref is only set for pull requests. For the main branches we fall back to github.run_id which is unique and always available.
09cad40 to
d3b8a78
Compare
|
Done and done. Thank you for the review! I will adjust the commit message when merging. |
mvorisek
reviewed
Mar 7, 2023
TimWolla
approved these changes
Mar 7, 2023
|
@TimWolla I tested this on my private fork to be sure. I also checked if there's a way to add the merge commit to the same group to cancel the PR pipeline but unfortunately there's no information on the PR in the pipeline triggered by the merge. But this would be a nice to have, usually we wait for the pipeline to finish before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing many commits to a pull request in a short amount of time can stall the merge builds and also wastes energy unnecessarily. github.head_ref is only set for pull requests. For the main branches we fall back to github.run_id which is unique and always available.