Skip to content

Unify Windows CI log verbosity with linux #10817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Mar 9, 2023

  • unify Windows CI verbosity with linux CI
  • also prevent CI bat files to be run locally to prevent local files modification when run unintentionally

@mvorisek mvorisek changed the title Unify Windows CI log verbosity Unify Windows CI log verbosity for PHP 8.1 Mar 9, 2023
@mvorisek mvorisek changed the title Unify Windows CI log verbosity for PHP 8.1 Unify Windows CI log verbosity for PHP 8.1 branch Mar 9, 2023
@mvorisek mvorisek changed the title Unify Windows CI log verbosity for PHP 8.1 branch Unify Windows CI log verbosity with linux Mar 9, 2023
@mvorisek
Copy link
Contributor Author

@iluuu1994 can you please review?

@iluuu1994
Copy link
Member

The group change was made for PHP-8.2, it's consistent there for all CI platforms.

@mvorisek
Copy link
Contributor Author

yes, there should ne no change of the verbosity for PHP 8.2+

@iluuu1994
Copy link
Member

What I mean is that all other PHP 8.1 are still verbose. So this is already consistent in that way.

@iluuu1994 iluuu1994 closed this Mar 15, 2023
@mvorisek
Copy link
Contributor Author

please reopen, this is not true, try to open linux and Win in GH CI, the Win CI is much more verbose and takes long time to open on my PC as there are a lot of lines

also I would like the safety if merged to prevent the dangerous CI bat files to be run localy on Windows

@iluuu1994
Copy link
Member

I missed that this includes PASS, it makes sense to remove that.

@iluuu1994 iluuu1994 reopened this Mar 15, 2023
@iluuu1994 iluuu1994 closed this in f42e562 Mar 15, 2023
@mvorisek mvorisek deleted the php81_win_verbosity branch March 16, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants