Skip to content

Disable asan instrumentation for phpdbg_watchpoint_userfaultfd_thread #10818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Disable asan instrumentation for phpdbg_watchpoint_userfaultfd_thread #10818

wants to merge 1 commit into from

Conversation

iluuu1994
Copy link
Member

On gcc. It reports a false positive stack-overflow.

/cc @Girgias

@iluuu1994
Disable asan instrumentation for phpdbg_watchpoint_userfaultfd_thread
2f1e45e 
On gcc. It reports a false positive stack-overflow.
@iluuu1994 iluuu1994 requested a review from bwoebi March 9, 2023 20:53
@bwoebi
Copy link
Member

bwoebi commented Mar 9, 2023 •
edited
Loading

I suppose clang should also have it's attribute here? Or does it not fail on clang?

@iluuu1994
Copy link
Member Author

@bwoebi It actually works fine on Clang.

bwoebi
bwoebi approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, ... then, let me just ack :-)

@Girgias
Copy link
Member

Girgias commented Mar 9, 2023

Yay!

@iluuu1994 iluuu1994 closed this in f415ba6 Mar 9, 2023
@iluuu1994 iluuu1994 mentioned this pull request Apr 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees
No one assigned
Labels
SAPI: phpdbg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iluuu1994 @bwoebi @Girgias