Skip to content

Fix NUL byte in exception string terminating Exception::__toString() #10873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix NUL byte in exception string terminating Exception::__toString() #10873

wants to merge 2 commits into from

Conversation

iluuu1994
Copy link
Member

Fixes GH-10810

@iluuu1994 iluuu1994 mentioned this pull request Mar 17, 2023
Closed
Girgias
Girgias approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iluuu1994
Copy link
Member Author

Hmm, given that zend_printf_to_smart_str may be customized, I'm not sure if introducing a new formatter is safe as the customized version doesn't handle it yet. It might be better to use %Z for now.

@iluuu1994 iluuu1994 closed this in b5726c2 Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iluuu1994 @Girgias