-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Implement better diff for run-tests.php #10875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Diffing algorithm is borrowed from bless_tests.php Fixes phpGH-10806
0996960
to
e5e8366
Compare
Nit: I think it would be a bit nicer if the diffing code of |
The file is part of the distribution and might be copied separately, I wanted to avoid a new file that has to be copied for it to stay functional. Maybe we could create a functional diff file though that can be patched to avoid the diffing in bless.php. |
Aha okay, TIL. Best to ignore my comment then :-) |
Thank you. I can confirm this PR fixes the issue described in #10806.
AFAK this is required for |
3676918
to
f82ee7a
Compare
Turns out that algorithm uses a lot of memory (~200MB for a failing ASAN test, which is why the ASAN build crashed). I've switched it out for |
f82ee7a
to
cfdcd74
Compare
353e518
to
15b87e6
Compare
This should be ready. Since it's using a different algorithm from |
@mvorisek Sorry, since I basically completely changed the implementation it would be great if you could retest if this solves the problem for you. |
Diffing algorithm is borrowed from sebastian/diff
Fixes GH-10806
@mvorisek Does this fix the problem for you?