Skip to content

Fix GH-10885: Leaking stream_socket_server context #10886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-10885: Leaking stream_socket_server context #10886

wants to merge 1 commit into from

Conversation

iluuu1994
Copy link
Member

@iluuu1994 iluuu1994 commented Mar 20, 2023 •
edited
Loading

php_stream_context_set already increases the refcount.

@Girgias Girgias requested a review from bukka March 20, 2023 14:07
Girgias
Girgias approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible to me, just requested Jakub's review as he better versed in Streams

bukka
bukka reviewed Mar 20, 2023
View reviewed changes
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual fix looks good but the test strategy might be done differently.

@iluuu1994
Fix phpGH-10885: Leaking stream_socket_server context
a0a4d9d 
`php_stream_context_set` already increases the refcount.
@iluuu1994 iluuu1994 closed this in 122f128 Mar 20, 2023
@iluuu1994
Copy link
Member Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bukka bukka bukka approved these changes

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iluuu1994 @bukka @Girgias