Skip to content

ext/pdo_sqlite: simplifying sqlite3_exec usage. #10910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

devnexen
Copy link
Member

pdo_sqlite_error copy the error message via the php's allocator,
while the one from sqlite3_exec is unused.

pdo_sqlite_error copy the error message via the php's allocator,
 while the one from sqlite3_exec is unused.
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, that is indeed doing some useless allocations.

@devnexen devnexen merged commit 54f92fc into php:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants