Skip to content

Disallow parent dir components (..) in open_basedir() at runtime #10913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Disallow parent dir components (..) in open_basedir() at runtime #10913

wants to merge 1 commit into from
+45 −4

Conversation

iluuu1994
Copy link
Member

Fix GH-10469

@iluuu1994
Disallow parent dir components (..) in open_basedir() at runtime

Verified

This commit was signed with the committer’s verified signature.
iluuu1994 Ilija Tovilo
GPG key ID: A4F5D403F118200A
Verified
Learn about vigilant mode
163016f 
Fix phpGH-10469
@iluuu1994 iluuu1994 closed this in 61e98bf Mar 25, 2023
@bukka
Copy link
Member

bukka commented Mar 25, 2023

@iluuu1994 Did you just prohibit .. anywhere in the path? If so, it should be changed to not allow only jump out of cwd (you can count the dirs...)

@iluuu1994
Copy link
Member Author

@bukka Oh, that's a good idea. I missed this approach. I'll make the changes tomorrow. I suppose then backporting it would be fine too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iluuu1994 @bukka