ext/posix: proposing posix_eaccess. #10917
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Mar 26, 2023
ext/posix/posix.c
Outdated
Comment on lines
730
to
734
| path = expand_filepath(filename, NULL); | ||
| if (!path) { | ||
| POSIX_G(last_error) = EIO; | ||
| RETURN_FALSE; | ||
| } |
There was a problem hiding this comment.
Is this case the one where the path is empty? Maybe better to have a ValueError for this as this is a new function.
3c65cc6 to
84c17ac
Compare
Girgias
reviewed
Mar 26, 2023
ext/posix/posix.c
Outdated
|
|
||
| path = expand_filepath(filename, NULL); | ||
| if (!path) { | ||
| zend_argument_value_error(1, "cannot be empty"); |
There was a problem hiding this comment.
I think our standard writing is as such. @kocsismate is this correct?
Suggested change
| zend_argument_value_error(1, "cannot be empty"); | |
| zend_argument_value_error(1, "must not be empty"); |
There was a problem hiding this comment.
No, the wording is somehow cannot be empty :) We do have a couple of must not be empty as well, but it's much less than the former one
unlike access, it is not standard but available in enough platforms ; on linux it's euidaccess in reality eaccess being 'just' an alias. key difference is eaccess checks the effective user id instead.
Girgias
approved these changes
Mar 27, 2023
kocsismate
reviewed
Mar 28, 2023
| <?php | ||
|
|
||
| try { | ||
| posix_eaccess(str_repeat('bogus path', 1042)); |
There was a problem hiding this comment.
would it make sense to have a test for the happy path?
kocsismate
reviewed
Mar 28, 2023
| @@ -713,6 +713,44 @@ PHP_FUNCTION(posix_access) | |||
|
|
|||
| RETURN_TRUE; | |||
| } | |||
|
|
|||
| #ifdef HAVE_EACCESS | |||
| PHP_FUNCTION(posix_eaccess) | |||
There was a problem hiding this comment.
there should be an upgrading note added, right?
llaville
added a commit
to llaville/php-compatinfo-db
that referenced
this pull request
Oct 11, 2023
llaville
added a commit
to llaville/php-compatinfo-db
that referenced
this pull request
Nov 18, 2023
llaville
added a commit
to llaville/php-compatinfo-db
that referenced
this pull request
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unlike access, it is not standard but available in enough platforms ; on linux it's euidaccess in reality eaccess being 'just' an alias. key difference is eaccess checks the effective user id instead.