Add AMPHP, ReactPHP, Revolt PHP in community job #10933
Conversation
There was a problem hiding this comment.
The community builds already take quite long (4h30m):
https://github.com/php/php-src/actions/runs/4516744467/jobs/7955396917
6h is the maximum, I'm not sure if this might push it over the edge. If that becomes a problem we might try to create a base job that builds PHP, mark those as artifacts and then run separate jobs to test the libraries.
Also, could you temporarily copy this to push.yml so we can make sure this works?
|
I've been testing this on https://github.com/arnaud-lb/php-src/actions/runs/4519573556/jobs/7960141152, but it's not very stable yet. In particular, the amphp/byte-stream test suite sometimes causes an assertion failure in libsanitizer, that I can't reproduce locally. The job duration dangerously approaches 6h indeed. I'll see if I can manage to split it into separate jobs. |
|
I was not able to reproduce the ASAN assertion failure that occurred during the amphp/byte-stream test suite, so I've removed this package from the build, for now. The build is now stable. |
.github/workflows/nightly.yml
Outdated
| @@ -360,6 +360,27 @@ jobs: | |||
| echo opcache.enable_cli=1 >> /etc/php.d/opcache.ini | |||
| echo opcache.protect_memory=1 >> /etc/php.d/opcache.ini | |||
| echo opcache.jit_buffer_size=1G >> /etc/php.d/opcache.ini | |||
|
|
|||
There was a problem hiding this comment.
Nit: The file generally avoids newlines
This adds ~13m to each _COMMUNITY variant except PHP-80 |
This adds AMPHP, ReactPHP, Revolt PHP in community job, as an attempt to spot regressions around Fibers.