Skip to content

Use php_random_bytes_silent() where possible in gmp_init_random() #10944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2023
Merged

Use php_random_bytes_silent() where possible in gmp_init_random() #10944

merged 1 commit into from
Mar 26, 2023

Conversation

nielsdos
Copy link
Member

See GH-10942.

Q: does this need a mention in UPGRADING?

@nielsdos nielsdos requested a review from TimWolla March 25, 2023 23:00
@nielsdos nielsdos requested a review from Girgias as a code owner March 25, 2023 23:00
@nielsdos
Copy link
Member Author

Just checking: there does not need to be a NEWS/UPGRADING mention right?

@TimWolla
Copy link
Member

#6520 didn't add one and I don't think it's required here either: The externally visible behavior is not changed.

@nielsdos nielsdos merged commit 8317a14 into php:master Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla approved these changes

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: gmp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nielsdos @TimWolla @Girgias