Fix bug GH-11246 cli/get_set_process_title initialisation failure on MacOS (PHP >= 8.2) #11273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional PR along with PR #11247 targeting PHP>=8.2 due to commit b468d6f
Fixes #11246, when executing on MacOS it was found that the environ area my not be contiguous.
Checking the original Postgres implementation https://github.com/postgres/postgres/blob/master/src/backend/utils/misc/ps_status.c the PHP code fails if either argv or environ is non-contiguous whereas the original code only fails if argv is ever non-contiguous.
Additionally the end_of_area variable is changed even if we hit a non-contiguous environ section, another divergence from the original code