Skip to content

More usage of known zend_str instead of C string #11381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 8, 2023
Merged

More usage of known zend_str instead of C string #11381

merged 7 commits into from
Jun 8, 2023

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jun 6, 2023

There are still more cases where we can use a known zend_string instead of using C strings.

@Girgias Girgias force-pushed the use-known-count-str branch from f1babbb to f796c6a Compare June 6, 2023 16:15
@Girgias Girgias marked this pull request as ready for review June 6, 2023 17:14
@Girgias Girgias requested a review from dstogov as a code owner June 6, 2023 17:14
devnexen
devnexen approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me

adoy
adoy approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@adoy adoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Girgias Girgias mentioned this pull request Jun 7, 2023
Draft
@Girgias Girgias merged commit d5ad751 into php:master Jun 8, 2023
@Girgias Girgias deleted the use-known-count-str branch June 8, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adoy adoy adoy approved these changes

@devnexen devnexen devnexen approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

@iluuu1994 iluuu1994 Awaiting requested review from iluuu1994

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Category: Engine Extension: curl Extension: dom Extension: ftp Extension: iconv Extension: ldap Extension: opcache Extension: pdo_sqlite Extension: pgsql Extension: reflection Extension: session Extension: simplexml Extension: soap Extension: sodium Extension: spl Extension: standard Extension: xml SAPI: cli SAPI: fpm SAPI: phpdbg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Girgias @adoy @devnexen