fix file() flags error-check #11483
Closed
fix file() flags error-check #11483
+27
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the old flag check was flawed and would miss some flags, for example: file(__FILE__, FILE_APPEND); is invalid, but the old flags error check would miss it: https://3v4l.org/b2W9u
|
i think the ASAN_DEBUG_NTS test just randomly failed for completely unrelated reasons. anyone know how to re-run it? can't find a "re-run test" button 🤔 |
Only maintainers can re-run it. But it's fine, it's a known flaky test. |
iluuu1994
approved these changes
Jun 21, 2023
|
Just fyi: I borrowed the idea and implemented a check in PHPStan, so we can detect similar errors even on older PHP versions |
|
@iluuu1994 added note in UPGRADING (and that caused a merge conflict, but fixed it) |
|
Thanks! Let's wait for Jakubs review since he's code owner. |
bukka
approved these changes
Jun 23, 2023
|
Thanks @divinity76! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the old flag check was flawed and would miss some invalid flags, for example:
is invalid, but the old flags error check would miss it: https://3v4l.org/b2W9u
the new check is also about 7% faster: https://quick-bench.com/q/j3k_unXcE91gVdTRH9Dm0nxpDUA