Skip to content

Fix crash when an invalid callback function is passed to CURLMOPT_PUSHFUNCTION #11639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix crash when an invalid callback function is passed to CURLMOPT_PUSHFUNCTION #11639

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Jul 8, 2023 •
edited
Loading

Previously this caused a SIGABRT.

Found using my homebrew static analyser.

@nielsdos nielsdos requested a review from adoy July 8, 2023 17:54
adoy
adoy reviewed Jul 8, 2023
View reviewed changes
Copy link
Member

@adoy adoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm :) Thanks

@nielsdos nielsdos closed this in 3ccd8d7 Jul 8, 2023
@nielsdos
Copy link
Member Author

nielsdos commented Jul 8, 2023

Thanks for the fast review ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adoy adoy adoy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @adoy