ext/sockets/tests/mcast_ipv6_*.phpt: suppress no-ipv6 warning #11651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
approved these changes
Jul 10, 2023
| $s = socket_create(AF_INET6, SOCK_DGRAM, SOL_UDP); | ||
| // hide the output from socket_create() because it can raise | ||
| // a warning if (for example) the linux kernel is lacking ipv6 | ||
| @$s = socket_create(AF_INET6, SOCK_DGRAM, SOL_UDP); |
There was a problem hiding this comment.
Suggested change
| @$s = socket_create(AF_INET6, SOCK_DGRAM, SOL_UDP); | |
| $s = @socket_create(AF_INET6, SOCK_DGRAM, SOL_UDP); |
Nit, same in the other files.
| // a warning if (for example) the linux kernel is lacking ipv6 | ||
| @$s = socket_create(AF_INET6, SOCK_DGRAM, SOL_UDP); | ||
| if ($s === false) { | ||
| die("skip unable to create socket"); |
There was a problem hiding this comment.
Suggested change
| die("skip unable to create socket"); | |
| die("skip unable to create socket"); |
Nit. Yes, I see the existing code above uses 2 but we still use 4 everywhere else 🙂
There was a problem hiding this comment.
No problem, fixed, thanks!
945b34b to
f70cb96
Compare
These three tests try to create an ipv6 socket with socket_create() to determine if they should be skipped. On certain systems lacking ipv6 support, however, the call to socket_create() itself raises a warning: BORK Warning: socket_create(): Unable to create socket [97]: Address family not supported by protocol in ... The output is "borked" because the return value (false) is expected but the text of the warning is not. This commit uses the error control operator (@) to hide the warning. Afterwards the tests are skipped normally on such a system.
f70cb96 to
8841bb0
Compare
|
Thank you @orlitzky! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These three tests try to create an ipv6 socket with socket_create() to determine if they should be skipped. On certain systems lacking ipv6 support, however, the call to socket_create() itself raises a warning:
BORK Warning: socket_create(): Unable to create socket [97]: Address
family not supported by protocol in ...
The output is "borked" because the return value (false) is expected but the text of the warning is not. This commit uses the error control operator (@) to hide the warning. Afterwards the tests are skipped normally on such a system.