Implement DOMElement::insertAdjacent{Element,Text}

[nielsdos]

ref: https://dom.spec.whatwg.org/#dom-element-insertadjacentelement
ref: https://dom.spec.whatwg.org/#dom-element-insertadjacenttext

[Girgias]

I didn't really have a look at the test cases. @theseer do you want to double check?

[Girgias]

The spec seem to indicate that a DOMException must be thrown:

Suggested change

	php_dom_throw_error(SYNTAX_ERR, dom_get_strict_error(this_intern->document));
	return INSERT_ADJACENT_RES_FAILED;
	php_dom_throw_error(SYNTAX_ERR, true);
	return INSERT_ADJACENT_RES_FAILED;

[nielsdos]

Yes, but strangely PHP offers an "stricterror" option (default true) which allows you to get warnings instead of exceptions.
And that maybe doesn't even violate spec, because from https://webidl.spec.whatwg.org/#dfn-throw

The resulting behavior from creating and throwing an exception is language binding specific.

[nielsdos]

See https://www.w3.org/TR/2004/REC-DOM-Level-3-Core-20040407/core.html#Document3-strictErrorChecking for more info

[Girgias]

Yeah PHP extension used to have the trifecto of no warning/exception, warnings, exceptions. I think mainly because prior to the introduction of exception warnings were the only way.

We probably should get rid of those and only allow silent or exception behaviour (similarly to the SQLite3 RFC) but that's future scope

[theseer]

The existing tests look good to me.

Two questions:

• Mozlla (according to https://developer.mozilla.org/en-US/docs/Web/API/Element/insertAdjacentElement) additionally throws a TypeError exception. Not sure if that is relevant for us.

• The spec mentions that the where string should be case insensitive. All examples in the test are fully lowercase. Do we need or want to explicitly cover alternative cases?

[nielsdos]

The existing tests look good to me.

Thanks for having a look.

Two questions:

* Mozlla (according to https://developer.mozilla.org/en-US/docs/Web/API/Element/insertAdjacentElement) additionally throws a `TypeError` exception. Not sure if that is relevant for us.

Thrown if the element specified is not a valid element.

Not sure what that means to be honest. It seems Firefox specific. Spec doesn't define it so I'd say we should ignore this.

* The spec mentions that the `where` string should be case insensitive. All examples in the test are fully lowercase. Do we need or want to explicitly cover alternative cases?

Good point, I'll add a small test for this.