Skip to content

zend vm savee registers support for riscv 64. #11773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2023
Merged

zend vm savee registers support for riscv 64. #11773

merged 1 commit into from
Jul 24, 2023

Conversation

devnexen
Copy link
Member

x8 being already reserved, we can only pull x18 to x27.

@devnexen
zend vm savee registers support for riscv 64.
819a7fa 
x8 being already reserved, we can only pull x18 to x27.
dstogov
dstogov approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot test this, but this looks OK.

@devnexen devnexen merged commit 2778b5d into php:master Jul 24, 2023
@andypost
Copy link
Contributor

Should it be backported to 8.2?

@dstogov
Copy link
Member

dstogov commented Jul 24, 2023

Should it be backported to 8.2?

I think, no.

jorgsowa pushed a commit to jorgsowa/php-src that referenced this pull request Jul 26, 2023
@devnexen @jorgsowa
zend vm savee registers support for riscv 64. (php#11773)
5d6d66b 
x8 being already reserved, we can only pull x18 to x27.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstogov dstogov dstogov approved these changes

@iluuu1994 iluuu1994 Awaiting requested review from iluuu1994

Assignees
No one assigned
Labels
Category: Build System Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devnexen @andypost @dstogov