RFC: Constructor behaviour of internal classes #1178
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t from the class it is actually changing.
| zend_replace_error_handling(EH_THROW, IntlException_ce_ptr, &zeh TSRMLS_CC); | ||
| rv = zend_parse_parameters(ZEND_NUM_ARGS(), "|s!s!", | ||
| &dest, &dest_len, &src, &src_len); | ||
| zend_restore_error_handling(&zeh TSRMLS_CC); |
There was a problem hiding this comment.
Thanks, was spaces instead of tab.
|
Superseded by #1205. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for https://wiki.php.net/rfc/internal_constructor_behaviour
This is not ready to merge - I still need to correct a few tests that have a difference in text for the warning vs the exception, but someone asked be to make it a PR to be easier to read.