Skip to content

Add class constant types to Phar extension #11826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2023
Merged

Add class constant types to Phar extension #11826

merged 1 commit into from
Aug 21, 2023

Conversation

Ayesh
Copy link
Member

@Ayesh Ayesh commented Jul 29, 2023

Learned from ae3646d, this adds types to class constants in ext-phar.

@Ayesh Ayesh requested a review from kocsismate as a code owner July 29, 2023 16:50
@kocsismate kocsismate requested a review from Girgias August 15, 2023 06:29
@kocsismate
Copy link
Member

I'm fine with doing this, but as this is a breaking change, let's wait for the opinion of others.

Girgias
Girgias approved these changes Aug 20, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would imagine this to be fine.

Just needs an entry in UPGRADING

@Ayesh
Add class constant types to Phar extension
40e545f 
Learned from ae3646d, this adds types to class constants in ext-phar.
@Ayesh Ayesh force-pushed the phar-class-const-types branch from c535749 to 40e545f Compare August 21, 2023 03:43
@Ayesh
Copy link
Member Author

Ayesh commented Aug 21, 2023

Thank you @Girgias - I pushed with a relevant UPGRADING file changes. I think we should also add a similar note for the Zip extension, which also declares class constants in 8.3.

@kocsismate kocsismate merged commit 1887f02 into php:master Aug 21, 2023
jorgsowa pushed a commit to jorgsowa/php-src that referenced this pull request Aug 24, 2023
@Ayesh @jorgsowa
Add class constant types to Phar extension (php#11826)
9beb663
@Ayesh Ayesh deleted the phar-class-const-types branch February 27, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees
No one assigned
Labels
Extension: phar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ayesh @kocsismate @Girgias