Zend: Fix memory leak in ++/-- when overloading fetch access #11859
Conversation
| Cannot increment array | ||
| Cannot decrement array |
There was a problem hiding this comment.
Not sure why the op type becomes an array, but that seems minor.
Zend/zend_vm_def.h
Outdated
| if (UNEXPECTED(EG(exception))) { | ||
| /* Smart branch expects result to be set with exceptions */ | ||
| FREE_OP1(); | ||
| /* opcodes are expected to set the result value */ | ||
| if (UNEXPECTED(RETURN_VALUE_USED(opline))) { | ||
| ZVAL_NULL(EX_VAR(opline->result.var)); | ||
| } |
There was a problem hiding this comment.
Are you sure you need all this code?
Removing the whole if (UNEXPECTED(EG(exception))) {...} shouldn't change anything.
There was a problem hiding this comment.
Don't think so no, I'm still figuring out the VM at times.
I think my rationale was that I wanted to deal with stuff localy to be sure I understand what is going on. But as nothing else happens here this code can be dropped.
| } while (0); | ||
|
|
||
| /* opcodes are expected to set the result value */ |
There was a problem hiding this comment.
Nit: This comment seems rather useless. I'd prefer just removing it. result is primarily assigned for when the result of ++$foo is used. Nobody will understand the relation to the throw helper issue from this comment.
Addresses #11759 (comment)
Also fixed the comments as per: #11850 (comment)