Assert ptr_ptr value of TMP|CONST isn't used

[iluuu1994]

We require valid code for compilation to succeed, but these paths should always be guarded by OPx_TYPE checks and never execute. Add an assertion to verify.

Motivated by the comment here: #11788 (comment)

[dstogov]

Looks OK.

Could you please check the effect of this patch (e.g. size sapi/cli/php)
Does it reduce the code size?

[iluuu1994]

Does it reduce the code size?

It didn't, it went from 28507008 to 28507168 with a ./configure --disable-debug --disable-all. That's an increase of 160 bytes.

[dstogov]

Does it reduce the code size?

It didn't, it went from 28507008 to 28507168 with a ./configure --disable-debug --disable-all. That's an increase of 160 bytes.

This looks strange. I though this should remove some dead code paths. Try to take a look into disassemble of some of the affected handlers to understand what is going on.

[iluuu1994]

I see no difference in any of the assembly of any of the functions that now contain the zend_get_bad_ptr(). This sounds correct, as they should all already be guarded with a op_type check and thus eliminated already. Disassembling and comparing the entire binaries also shows no difference. I guess the difference comes from .rodata somewhere.

[dstogov]

OK. merge this