Skip to content

Remove unused HAVE_GCC_GLOBAL_REGS shell variable #11877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2023
Merged

Remove unused HAVE_GCC_GLOBAL_REGS shell variable #11877

merged 1 commit into from
Aug 7, 2023

Conversation

petk
Copy link
Member

@petk petk commented Aug 4, 2023

This is only a shell script variable when configure is created and can be removed.

@petk petk requested a review from iluuu1994 as a code owner August 4, 2023 21:55
iluuu1994
iluuu1994 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also misleading for somebody like me who doesn't understand autoconf well, since lots of code checks for defined(HAVE_GCC_GLOBAL_REGS), which would be true if it were an actual macro with the value no. Thanks @petk!

@petk petk merged commit ba35ff0 into php:master Aug 7, 2023
@petk petk deleted the patch-autoconf-clean-unused-variable branch August 7, 2023 22:52
jorgsowa pushed a commit to jorgsowa/php-src that referenced this pull request Aug 16, 2023
@petk
Remove unused HAVE_GCC_GLOBAL_REGS shell variable (php#11877)
551bcee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

Assignees
No one assigned
Labels
Category: Build System Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petk @iluuu1994