Skip to content

Fix manually calling __construct() on DOM classes #11894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix manually calling __construct() on DOM classes #11894

wants to merge 3 commits into from

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Aug 6, 2023

No description provided.

Girgias
Girgias approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even if I find this to be a pretty dubious usage of __construct(), but I suppose this is required for a custom class extending the DOM nodes that need to call the construct method.

@nielsdos
Copy link
Member Author

nielsdos commented Aug 7, 2023

LGTM, even if I find this to be a pretty dubious usage of __construct(), but I suppose this is required for a custom class extending the DOM nodes that need to call the construct method.

I agree this is majorly cursed

@nielsdos nielsdos closed this in 08c4db7 Aug 7, 2023
jorgsowa pushed a commit to jorgsowa/php-src that referenced this pull request Aug 16, 2023
@nielsdos
Fix manually calling __construct() on DOM classes
f2018e8 
Closes phpGH-11894.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @Girgias