BCmath extension code reformatting #11896
Merged
+265
−286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Aug 11, 2023
Girgias
reviewed
Aug 12, 2023
|
|
||
| prodlen = n1len+n2len+1; | ||
| int prodlen = n1len + n2len + 1; |
There was a problem hiding this comment.
Note to myself: why is n2len an int and probably should be size_t. Ditto for prodlen
Girgias
reviewed
Aug 12, 2023
|
Okay so it was the type change of bc_precision which was causing an issue. If the rest of the CI is happy I'm going to merge as is, and we can follow-up the other nits/issues |
|
Note: S390X is a big-endian architecture compared to X86 being little-endian, as such the cast to |
Girgias
approved these changes
Aug 13, 2023
jorgsowa
added a commit
to jorgsowa/php-src
that referenced
this pull request
Aug 16, 2023
Re-formats the BCmath extension to have consistent formatting. Mostly, it adds the spaces in calculations to have them more readable. Also: - removes unused headers - removes few variables which are used only once in the code Co-authored-by: George Peter Banyard <girgias@php.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-formats the bcmath extension to have consistent formatting. Mostly it adds the spaces in calculations to have them more readable.
Also: