Sync --enable-mysqlnd-compression-support option #12006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This syncs the style of the --enable-mysqlnd-compression-support option name, otherwise in Autoconf both --enable-foo_bar and --enable-foo-bar work. Also the configure output message is synced to match the check information.
Girgias
approved these changes
Aug 20, 2023
|
With this change this will still work though: And the configuration will be also the same. The output text is misleading though. It is checking to enable it. So, even if someone is out there using the --enable-mysqlnd_compression_support option, they will still have it working even after this patch. |
|
Ah, okay then, I don't understand build systems |
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Aug 24, 2023
This syncs the style of the --enable-mysqlnd-compression-support option name, otherwise in Autoconf both --enable-foo_bar and --enable-foo-bar work. Also the configure output message is synced to match the check information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This syncs the style of the --enable-mysqlnd-compression-support option name, otherwise in Autoconf both --enable-foo_bar and --enable-foo-bar work.
Also the configure output message is synced to match the check information.
Instead of this:
this reads a bit better: