Fix GH-11982: str_getcsv returns null byte for unterminated enclosure #12047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this is more edge case and there is a small chance someone handles it already in their code, I'm targeting just master (8.3) for this fix and will also update UPGRADING accordingly just in case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for GH-11982 which is caused by extra increment of the buffer pointer during parsing. It doesn't take into account the fact that it might be incremented too much in case of an enclosure being at the end of line. The fix adds two checks for that in the branches used by
str_getcsvandfgetcsv. If it is identified, it goes back by one character.