Fix bug #60110 (fclose(), file_put_contents(), copy() do not return false properly) #12067
+107
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have been looking to the pipeline errors and this has got some bigger impact as it is impacting exec exit code as well so this needs a proper analysis of the potential and possibly considering some other ways how to inform users about failed flush. Something needs to be done about this but it's too late for 8.3 so this should hopefully happen in the following minor or major (if BC impact is too big) version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the return value to false if the flush operation fails. That introduces possibility to check if those operations have been executed correctly which wasn't previously possible.