Skip to content

Fix #12123 Make _ZEND_TYPE_PREFIX apply only for MSVC #12136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix #12123 Make _ZEND_TYPE_PREFIX apply only for MSVC #12136

wants to merge 1 commit into from
+1 −1

Conversation

kocsismate
Copy link
Member

Hopefully this fixes #12123

@kocsismate kocsismate requested a review from iluuu1994 September 6, 2023 08:07
@kocsismate kocsismate requested a review from dstogov as a code owner September 6, 2023 08:07
@kocsismate kocsismate changed the base branch from master to PHP-8.3 September 6, 2023 09:30
@kocsismate
Fix php#12123 Make _ZEND_TYPE_PREFIX apply only for MSVC

Verified

This commit was signed with the committer’s verified signature.
kocsismate Máté Kocsis
GPG key ID: FD055E41728BF310
Verified
Learn about vigilant mode
704fab0
dstogov
dstogov approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see problems.

iluuu1994
iluuu1994 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. I think we're relying on a g++ extension for designated initializers in other compilers, but I guess that's fine.

@kocsismate kocsismate deleted the fix-gh-12123 branch September 10, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994

@dstogov dstogov

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile error on MacOS with C++ extension when using ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX
3 participants
@kocsismate @iluuu1994 @dstogov