Zend: Remove dependency on zend.h for certain headers #12166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to move AST definitions out from zend_compile.h and into zend_ast.h
iluuu1994
reviewed
Sep 9, 2023
c6bc5d6 to
44e77f7
Compare
|
I welcome this change, because it follows the spirit of https://wiki.php.net/rfc/include_cleanup but it is surprising that this PR got merged, even though similar PRs from me were rejected. |
|
Note that this PR adds a comment to an php-src/Zend/zend_objects_API.h Line 26 in ae42053 This was also something I proposed in https://wiki.php.net/rfc/include_cleanup but 90% of all voters rejected this idea, saying it should not be "allowed to document an #include line with a code comment". @dstogov also rejected this. @dstogov, did you miss this part of the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to move AST definitions out from zend_compile.h and into zend_ast.h
The motivation for this is to be able to move the FCC/FCI struct declarations and the relevant functions into their own header, so that it can be included in
zend_gc.hand movezend_get_gc_buffer_add_fcc()fromZend_API.htozend_gc.h.However, currently
zend_gc.hdoes not depend onzend.hand I don't think it should, howeverOBJ_RELEASE()which is used byzend_fcc_dtor()(which would logically be moved to the new header for FCI/FCC strucs) means it would have a dependency onZend/zend_objects_API.hthus the starting point for the dependency reduction.