Skip to content

Move static property check to assert #12239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2023
Merged

Move static property check to assert #12239

merged 1 commit into from
Sep 19, 2023

Conversation

iluuu1994
Copy link
Member

Staticness incompatiblity must error before attempting to declare the property.

@iluuu1994
Move static property check to assert
0338480 
Staticness incompatiblity must error before attempting to declare the property.
@iluuu1994 iluuu1994 requested a review from dstogov as a code owner September 18, 2023 13:05
dstogov
dstogov approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see problems.

I wander, if this check makes sense for user classes at all.
Can we eliminate it, adding ce->type == ZEND_INTERNAL_CLASS before the hash lookup?

@iluuu1994
Copy link
Member Author

@dstogov We can't, because zend_declare_typed_property is used from zend_inheritance.c in zend_do_traits_property_binding for user classes.

@iluuu1994 iluuu1994 merged commit f957335 into php:master Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstogov dstogov dstogov approved these changes

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iluuu1994 @dstogov